From: Dan Carpenter Date: Mon, 4 Nov 2013 12:58:56 +0000 (+0300) Subject: netfilter: nft_compat: use _safe version of list_for_each X-Git-Tag: v3.13-rc1~105^2~63^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c359c4157cf0d852387aff2f2d83fef039aadc2c;p=platform%2Fkernel%2Flinux-stable.git netfilter: nft_compat: use _safe version of list_for_each We need to use the _safe version of list_for_each_entry() here otherwise we have a use after free bug. Signed-off-by: Dan Carpenter Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/nft_compat.c b/net/netfilter/nft_compat.c index 4811f76..a82667c 100644 --- a/net/netfilter/nft_compat.c +++ b/net/netfilter/nft_compat.c @@ -634,9 +634,9 @@ nft_match_select_ops(const struct nft_ctx *ctx, static void nft_match_release(void) { - struct nft_xt *nft_match; + struct nft_xt *nft_match, *tmp; - list_for_each_entry(nft_match, &nft_match_list, head) + list_for_each_entry_safe(nft_match, tmp, &nft_match_list, head) kfree(nft_match); } @@ -705,9 +705,9 @@ nft_target_select_ops(const struct nft_ctx *ctx, static void nft_target_release(void) { - struct nft_xt *nft_target; + struct nft_xt *nft_target, *tmp; - list_for_each_entry(nft_target, &nft_target_list, head) + list_for_each_entry_safe(nft_target, tmp, &nft_target_list, head) kfree(nft_target); }