From: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date: Fri, 6 Jun 2014 08:35:20 +0000 (+0200)
Subject: waylandsink: remove the OBJECT_LOCK from set_caps()
X-Git-Tag: 1.19.3~507^2~10814
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c323171dc105210f6a4d986b0a4648bbe231df3a;p=platform%2Fupstream%2Fgstreamer.git

waylandsink: remove the OBJECT_LOCK from set_caps()

It's not really necessary, this method is protected from GstBaseSink with the PREROLL_LOCK
---

diff --git a/ext/wayland/gstwaylandsink.c b/ext/wayland/gstwaylandsink.c
index 1a911d6..a75c640 100644
--- a/ext/wayland/gstwaylandsink.c
+++ b/ext/wayland/gstwaylandsink.c
@@ -422,7 +422,6 @@ gst_wayland_sink_set_caps (GstBaseSink * bsink, GstCaps * caps)
   static GstAllocationParams params = { 0, 0, 0, 15, };
 
   sink = GST_WAYLAND_SINK (bsink);
-  GST_OBJECT_LOCK (sink);
 
   GST_DEBUG_OBJECT (sink, "set caps %" GST_PTR_FORMAT, caps);
 
@@ -462,34 +461,28 @@ gst_wayland_sink_set_caps (GstBaseSink * bsink, GstCaps * caps)
   gst_object_replace ((GstObject **) & sink->pool, (GstObject *) newpool);
   gst_object_unref (newpool);
 
-  GST_OBJECT_UNLOCK (sink);
   return TRUE;
 
 invalid_format:
   {
     GST_DEBUG_OBJECT (sink,
         "Could not locate image format from caps %" GST_PTR_FORMAT, caps);
-    goto failure;
+    return FALSE;
   }
 unsupported_format:
   {
     GST_DEBUG_OBJECT (sink, "Format %s is not available on the display",
         gst_wayland_format_to_string (format));
-    goto failure;
+    return FALSE;
   }
 pool_failed:
   {
     GST_DEBUG_OBJECT (sink, "Failed to create new pool");
-    goto failure;
+    return FALSE;
   }
 config_failed:
   {
     GST_DEBUG_OBJECT (bsink, "failed setting config");
-    goto failure;
-  }
-failure:
-  {
-    GST_OBJECT_UNLOCK (sink);
     return FALSE;
   }
 }