From: Andy Shevchenko Date: Mon, 2 Jan 2023 20:29:32 +0000 (+0200) Subject: usb: typec: intel_pmc_mux: Don't leak the ACPI device reference count X-Git-Tag: v6.6.17~5457^2~185 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c3194949ae8fcbe2b7e38670e7c6a5cfd2605edc;p=platform%2Fkernel%2Flinux-rpi.git usb: typec: intel_pmc_mux: Don't leak the ACPI device reference count When acpi_dev_get_memory_resources() fails, the reference count is left bumped. Drop it as it's done in the other error paths. Fixes: 43d596e32276 ("usb: typec: intel_pmc_mux: Check the port status before connect") Signed-off-by: Andy Shevchenko Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20230102202933.15968-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c index fdbf369..87e2c913 100644 --- a/drivers/usb/typec/mux/intel_pmc_mux.c +++ b/drivers/usb/typec/mux/intel_pmc_mux.c @@ -614,8 +614,10 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc) INIT_LIST_HEAD(&resource_list); ret = acpi_dev_get_memory_resources(adev, &resource_list); - if (ret < 0) + if (ret < 0) { + acpi_dev_put(adev); return ret; + } rentry = list_first_entry_or_null(&resource_list, struct resource_entry, node); if (rentry)