From: Igor Kudrin Date: Tue, 2 Jul 2019 09:57:28 +0000 (+0000) Subject: [DWARF] Simplify dumping of a .debug_addr section. X-Git-Tag: llvmorg-10-init~1493 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c310b1aaed65eb8b2f61860aec48565ef3e2b0f8;p=platform%2Fupstream%2Fllvm.git [DWARF] Simplify dumping of a .debug_addr section. This patch removes the part which tried to interpret addresses in that section as offsets and simplifies the remaining code. Differential Revision: https://reviews.llvm.org/D64020 llvm-svn: 364896 --- diff --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp index 6ab2a26..5862653 100644 --- a/llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp +++ b/llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp @@ -147,28 +147,13 @@ void DWARFDebugAddrTable::dump(raw_ostream &OS, DIDumpOptions DumpOpts) const { HeaderData.Length, HeaderData.Version, HeaderData.AddrSize, HeaderData.SegSize); - static const char *Fmt32 = "0x%8.8" PRIx64; - static const char *Fmt64 = "0x%16.16" PRIx64; - std::string AddrFmt = "\n"; - std::string AddrFmtVerbose = " => "; - if (HeaderData.AddrSize == 4) { - AddrFmt.append(Fmt32); - AddrFmtVerbose.append(Fmt32); - } - else { - AddrFmt.append(Fmt64); - AddrFmtVerbose.append(Fmt64); - } - if (Addrs.size() > 0) { - OS << "Addrs: ["; - for (uint64_t Addr : Addrs) { - OS << format(AddrFmt.c_str(), Addr); - if (DumpOpts.Verbose) - OS << format(AddrFmtVerbose.c_str(), - Addr + HeaderOffset + sizeof(HeaderData)); - } - OS << "\n]\n"; + const char *AddrFmt = (HeaderData.AddrSize == 4) ? "0x%8.8" PRIx64 "\n" + : "0x%16.16" PRIx64 "\n"; + OS << "Addrs: [\n"; + for (uint64_t Addr : Addrs) + OS << format(AddrFmt, Addr); + OS << "]\n"; } }