From: Jan Schmidt <jan@centricular.com>
Date: Fri, 12 Aug 2022 10:20:43 +0000 (+1000)
Subject: qtdemux: Avoid crash on reconfiguring.
X-Git-Tag: 1.22.0~1092
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c2fa0b50ce66b95ef552864ca2a00638c523ddc8;p=platform%2Fupstream%2Fgstreamer.git

qtdemux: Avoid crash on reconfiguring.

When reconfiguring a stream that never created
an output pad, don't access a NULL GstPad pointer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2869>
---

diff --git a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c
index d9f118c..7ce652a 100644
--- a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c
+++ b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c
@@ -13596,7 +13596,8 @@ qtdemux_reuse_and_configure_stream (GstQTDemux * qtdemux,
 
   /* unset new_stream to prevent stream-start event, unless we are EOS in which
    * case we need to force one through */
-  newstream->new_stream = GST_PAD_IS_EOS (newstream->pad);
+  newstream->new_stream = newstream->pad != NULL
+      && GST_PAD_IS_EOS (newstream->pad);
 
   return gst_qtdemux_configure_stream (qtdemux, newstream);
 }