From: Cosmin Paraschiv Date: Mon, 29 Apr 2013 23:53:09 +0000 (+0930) Subject: lguest: improve code readability in lg_cpu_start. X-Git-Tag: upstream/snapshot3+hdmi~5216^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c2ecd51531c881c8d47d77ea30395f7f03d42da3;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git lguest: improve code readability in lg_cpu_start. Make the container_of call friendlier and fix some comment slip-ups. Signed-off-by: Cosmin Paraschiv Cc: Daniel Baluta Signed-off-by: Rusty Russell --- diff --git a/drivers/lguest/lguest_user.c b/drivers/lguest/lguest_user.c index ff4a0bc..4263f4c 100644 --- a/drivers/lguest/lguest_user.c +++ b/drivers/lguest/lguest_user.c @@ -250,13 +250,13 @@ static ssize_t read(struct file *file, char __user *user, size_t size,loff_t*o) */ static int lg_cpu_start(struct lg_cpu *cpu, unsigned id, unsigned long start_ip) { - /* We have a limited number the number of CPUs in the lguest struct. */ + /* We have a limited number of CPUs in the lguest struct. */ if (id >= ARRAY_SIZE(cpu->lg->cpus)) return -EINVAL; /* Set up this CPU's id, and pointer back to the lguest struct. */ cpu->id = id; - cpu->lg = container_of((cpu - id), struct lguest, cpus[0]); + cpu->lg = container_of(cpu, struct lguest, cpus[id]); cpu->lg->nr_cpus++; /* Each CPU has a timer it can set. */ @@ -270,7 +270,7 @@ static int lg_cpu_start(struct lg_cpu *cpu, unsigned id, unsigned long start_ip) if (!cpu->regs_page) return -ENOMEM; - /* We actually put the registers at the bottom of the page. */ + /* We actually put the registers at the end of the page. */ cpu->regs = (void *)cpu->regs_page + PAGE_SIZE - sizeof(*cpu->regs); /*