From: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date: Tue, 6 Mar 2012 11:47:33 +0000 (+0100)
Subject: xvimagesink: Fix 'comparison of unsigned expression >= 0 is always true'
X-Git-Tag: 1.19.3~511^2~6555^2~59
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c2dc843c7edc9ced051fae10d2f96bd20bbb0fa2;p=platform%2Fupstream%2Fgstreamer.git

xvimagesink: Fix 'comparison of unsigned expression >= 0 is always true'

-1 aka 0xffffffff is the only possible 'negative' value that is used
as a special value for 'not set' here. All other positive values are
valid.
---

diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c
index ccfdaae..29fe98c 100644
--- a/sys/xvimage/xvimagesink.c
+++ b/sys/xvimage/xvimagesink.c
@@ -1426,7 +1426,7 @@ gst_xvimagesink_get_xv_support (GstXvImageSink * xvimagesink,
     xcontext->adaptors[i] = g_strdup (adaptors[i].name);
   }
 
-  if (xvimagesink->adaptor_no >= 0 &&
+  if (xvimagesink->adaptor_no != -1 &&
       xvimagesink->adaptor_no < xcontext->nb_adaptors) {
     /* Find xv port from user defined adaptor */
     gst_lookup_xv_port_from_adaptor (xcontext, adaptors,