From: Ralf Baechle Date: Wed, 9 Oct 2013 12:08:09 +0000 (+0200) Subject: uprobes: Remove the wrong __weak attribute X-Git-Tag: upstream/snapshot3+hdmi~4038^2~17^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c2d3f25dda016d9697c5416810d4528770f0a281;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git uprobes: Remove the wrong __weak attribute linux/uprobes.h declares arch_uprobe_skip_sstep() as a weak function. But as there is no definition of generic version so when trying to build uprobes for an architecture that doesn't yet have a arch_uprobe_skip_sstep() implementation, the vmlinux will try to call arch_uprobe_skip_sstep() somehwere in Stupidhistan leading to a system crash. We rather want a proper link error so remove arch_uprobe_skip_sstep(). Signed-off-by: Ralf Baechle Signed-off-by: Oleg Nesterov --- diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index 06f28be..e6fba62 100644 --- a/include/linux/uprobes.h +++ b/include/linux/uprobes.h @@ -123,7 +123,7 @@ extern int uprobe_post_sstep_notifier(struct pt_regs *regs); extern int uprobe_pre_sstep_notifier(struct pt_regs *regs); extern void uprobe_notify_resume(struct pt_regs *regs); extern bool uprobe_deny_signal(void); -extern bool __weak arch_uprobe_skip_sstep(struct arch_uprobe *aup, struct pt_regs *regs); +extern bool arch_uprobe_skip_sstep(struct arch_uprobe *aup, struct pt_regs *regs); extern void uprobe_clear_state(struct mm_struct *mm); #else /* !CONFIG_UPROBES */ struct uprobes_state {