From: Matthew Waters <matthew@centricular.com>
Date: Sun, 10 Apr 2022 00:55:02 +0000 (+1000)
Subject: subparse: don't try to index string with -1
X-Git-Tag: 1.22.0~1891
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c2ac57f6c970ab6129507bb04bcea47a693ab17f;p=platform%2Fupstream%2Fgstreamer.git

subparse: don't try to index string with -1

If the len of the string turns out to be 0, str[len - 1] resolved to
str[-1] which is not a good idea.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46543
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2147>
---

diff --git a/subprojects/gst-plugins-base/gst/subparse/gstsubparseelement.c b/subprojects/gst-plugins-base/gst/subparse/gstsubparseelement.c
index 7b40fd5..72af499 100644
--- a/subprojects/gst-plugins-base/gst/subparse/gstsubparseelement.c
+++ b/subprojects/gst-plugins-base/gst/subparse/gstsubparseelement.c
@@ -187,7 +187,7 @@ gst_sub_parse_data_format_autodetect (gchar * match_str)
       if (sscanf (str, "[%u:%02u.%02u]", &n1, &n2, &n3) == 3 ||
           sscanf (str, "[%u:%02u.%03u]", &n1, &n2, &n3) == 3) {
         all_lines_good = TRUE;
-      } else if (str[len - 1] == ']' && strchr (str, ':') != NULL) {
+      } else if (len > 0 && str[len - 1] == ']' && strchr (str, ':') != NULL) {
         all_lines_good = TRUE;
       } else {
         all_lines_good = FALSE;