From: Sebastian Dröge <sebastian@centricular.com>
Date: Thu, 29 Jan 2015 15:30:34 +0000 (+0100)
Subject: glcolorconvert: Add FIXME comment about possibility of non-Apple YCbCr422 rectangular... 
X-Git-Tag: 1.19.3~507^2~9441
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c2492b3a6b7b06906272fcd78ab29400f842fca5;p=platform%2Fupstream%2Fgstreamer.git

glcolorconvert: Add FIXME comment about possibility of non-Apple YCbCr422 rectangular textures
---

diff --git a/gst-libs/gst/gl/gstglcolorconvert.c b/gst-libs/gst/gl/gstglcolorconvert.c
index 50592ae..53e8c9d 100644
--- a/gst-libs/gst/gl/gstglcolorconvert.c
+++ b/gst-libs/gst/gl/gstglcolorconvert.c
@@ -850,6 +850,10 @@ _YUV_to_RGB (GstGLColorConvert * convert)
 
   if (in_tex_rectangular && apple_ycbcr
       && gst_buffer_n_memory (convert->inbuf) == 1) {
+    /* FIXME: We should probably also check if tex_target actually is using
+     * the Apple YCbCr422 extension. It could also be a normal UYVY texture
+     * with RB or Lum/Alpha
+     */
     info->frag_prog =
         g_strdup_printf (frag_APPLE_YUV_TO_RGB, pixel_order[0], pixel_order[1],
         pixel_order[2], pixel_order[3]);