From: Heiner Kallweit Date: Sat, 11 Mar 2023 18:34:45 +0000 (+0100) Subject: net: phy: smsc: bail out in lan87xx_read_status if genphy_read_status fails X-Git-Tag: v6.6.17~5289^2~33 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c22c3bbf351e4ce905f082649cffa1ff893ea8c1;p=platform%2Fkernel%2Flinux-rpi.git net: phy: smsc: bail out in lan87xx_read_status if genphy_read_status fails If genphy_read_status fails then further access to the PHY may result in unpredictable behavior. To prevent this bail out immediately if genphy_read_status fails. Fixes: 4223dbffed9f ("net: phy: smsc: Re-enable EDPD mode for LAN87xx") Signed-off-by: Heiner Kallweit Reviewed-by: Simon Horman Link: https://lore.kernel.org/r/026aa4f2-36f5-1c10-ab9f-cdb17dda6ac4@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 00d9eff..df2c543 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -199,8 +199,11 @@ static int lan95xx_config_aneg_ext(struct phy_device *phydev) static int lan87xx_read_status(struct phy_device *phydev) { struct smsc_phy_priv *priv = phydev->priv; + int err; - int err = genphy_read_status(phydev); + err = genphy_read_status(phydev); + if (err) + return err; if (!phydev->link && priv->energy_enable && phydev->irq == PHY_POLL) { /* Disable EDPD to wake up PHY */