From: Lidza Louina Date: Thu, 29 Aug 2013 23:00:37 +0000 (-0400) Subject: staging: dgnc: adds TODO X-Git-Tag: v3.12-rc1~183^2~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c211148fb6355f347ec819a05c3034acd56e75c1;p=kernel%2Fkernel-generic.git staging: dgnc: adds TODO This patchs adds a TODO for the driver. Signed-off-by: Lidza Louina Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO new file mode 100644 index 0000000..1ff2d18 --- /dev/null +++ b/drivers/staging/dgnc/TODO @@ -0,0 +1,17 @@ +* remove kzalloc casts +* checkpatch fixes +* sparse fixes +* fix use of sizeof(). Example replace sizeof(struct board_t) + with sizeof(*brd) and remove sizeof(char) +* change name of board_t to dgnc_board +* split two assignments into the two assignments on two lines; + don't use two equals signs +* remove unecessary comments +* remove unecessary error messages. Example kzalloc() has its + own error message. Adding an extra one is useless. +* use goto statements for error handling when appropriate +* there is a lot of unecessary code in the driver. It was + originally a standalone driver. Remove uneeded code. + +Please send patches to Greg Kroah-Hartman and +Cc: Lidza Louina