From: Dan Carpenter <error27@gmail.com>
Date: Mon, 20 Jun 2011 07:11:25 +0000 (+0300)
Subject: ASoC: adau1701: signedness bug in adau1701_write()
X-Git-Tag: v3.3-rc1~14^2~935
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c20974090e9093b8b69b37543cba381336c41ab7;p=platform%2Fkernel%2Flinux-3.10.git

ASoC: adau1701: signedness bug in adau1701_write()

"ret" is supposed to be signed here.  The current code will only
return -EIO on error, instead of a more appropriate error code such
as -EAGAIN etc.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Liam Girdwood <lrg@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
index 6c01bb6..2758d5f 100644
--- a/sound/soc/codecs/adau1701.c
+++ b/sound/soc/codecs/adau1701.c
@@ -140,9 +140,10 @@ static unsigned int adau1701_register_size(struct snd_soc_codec *codec,
 static int adau1701_write(struct snd_soc_codec *codec, unsigned int reg,
 		unsigned int value)
 {
-	unsigned int i, ret;
+	unsigned int i;
 	unsigned int size;
 	uint8_t buf[4];
+	int ret;
 
 	size = adau1701_register_size(codec, reg);
 	if (size == 0)