From: Davide Caratti Date: Tue, 11 Feb 2020 18:33:40 +0000 (+0100) Subject: net/sched: flower: add missing validation of TCA_FLOWER_FLAGS X-Git-Tag: v4.9.215~44 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c1edff5bde547da76bc1f2efc670a14928d499fd;p=platform%2Fkernel%2Flinux-amlogic.git net/sched: flower: add missing validation of TCA_FLOWER_FLAGS [ Upstream commit e2debf0852c4d66ba1a8bde12869b196094c70a7 ] unlike other classifiers that can be offloaded (i.e. users can set flags like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry to fl_policy. Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support") Signed-off-by: Davide Caratti Acked-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index eee299bb6bcf..de03b7b49e05 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -364,6 +364,7 @@ static const struct nla_policy fl_policy[TCA_FLOWER_MAX + 1] = { [TCA_FLOWER_KEY_TCP_DST_MASK] = { .type = NLA_U16 }, [TCA_FLOWER_KEY_UDP_SRC_MASK] = { .type = NLA_U16 }, [TCA_FLOWER_KEY_UDP_DST_MASK] = { .type = NLA_U16 }, + [TCA_FLOWER_FLAGS] = { .type = NLA_U32 }, }; static void fl_set_key_val(struct nlattr **tb,