From: H Hartley Sweeten Date: Tue, 26 Nov 2013 23:42:09 +0000 (-0700) Subject: staging: comedi: mpc624: remove unnecessary test X-Git-Tag: v3.14-rc1~13^2~616 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c1ce7f10543d616920a1eb772b993c7d7815d653;p=platform%2Fkernel%2Flinux-exynos.git staging: comedi: mpc624: remove unnecessary test It's not necessaary to vaidate insn->n passed to the (*insn_read) function. The for() loop following it will just be a NOP. Remove the test as well as the printk noise. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/mpc624.c b/drivers/staging/comedi/drivers/mpc624.c index 2d6add4..b105dd9 100644 --- a/drivers/staging/comedi/drivers/mpc624.c +++ b/drivers/staging/comedi/drivers/mpc624.c @@ -159,10 +159,6 @@ static int mpc624_ai_rinsn(struct comedi_device *dev, * We always write 0 to GNSWA bit, so the channel range is +-/10.1Vdc */ outb(insn->chanspec, dev->iobase + MPC624_GNMUXCH); - if (!insn->n) { - printk(KERN_INFO "MPC624: Warning, no data to acquire\n"); - return 0; - } for (n = 0; n < insn->n; n++) { /* Trigger the conversion */