From: Martin Kaiser Date: Sun, 20 Jun 2021 17:52:49 +0000 (+0200) Subject: staging: rtl8188eu: handle errors from dev_alloc_name X-Git-Tag: accepted/tizen/unified/20230118.172025~6889^2~71 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c1ccff4682da1e60f5d3820ba9381c977b562a29;p=platform%2Fkernel%2Flinux-rpi.git staging: rtl8188eu: handle errors from dev_alloc_name Fail the usb interface initialization if dev_alloc_name returns an error. Other wlan drivers like natsemi or atmel use the same error handling. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20210620175301.14988-1-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index 5ca54dc..ee209b2 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c @@ -387,8 +387,11 @@ static int rtw_usb_if1_init(struct usb_interface *pusb_intf) pr_debug("can't get autopm:\n"); /* alloc dev name after read efuse. */ - if (dev_alloc_name(pnetdev, padapter->registrypriv.ifname) < 0) + err = dev_alloc_name(pnetdev, padapter->registrypriv.ifname); + if (err < 0) { RT_TRACE(_module_os_intfs_c_, _drv_err_, ("dev_alloc_name, fail!\n")); + goto free_hal_data; + } netif_carrier_off(pnetdev);