From: Chuck Lever Date: Wed, 24 Oct 2007 04:08:54 +0000 (-0700) Subject: [TCP]: Remove unneeded implicit type cast when calling tcp_minshall_update() X-Git-Tag: v2.6.24-rc2~139^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c1bd24b76879f61b2d10609b0dabde400792a6ec;p=platform%2Fkernel%2Flinux-exynos.git [TCP]: Remove unneeded implicit type cast when calling tcp_minshall_update() The tcp_minshall_update() function is called in exactly one place, and is passed an unsigned integer for the mss_len argument. Make the sign of the argument match the sign of the passed variable in order to eliminate an unneeded implicit type cast and a mixed sign comparison in tcp_minshall_update(). Signed-off-by: Chuck Lever Signed-off-by: David S. Miller --- diff --git a/include/net/tcp.h b/include/net/tcp.h index 92049e6..d695cea 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -803,7 +803,7 @@ static inline int tcp_is_cwnd_limited(const struct sock *sk, u32 in_flight) return left <= tcp_max_burst(tp); } -static inline void tcp_minshall_update(struct tcp_sock *tp, int mss, +static inline void tcp_minshall_update(struct tcp_sock *tp, unsigned int mss, const struct sk_buff *skb) { if (skb->len < mss)