From: Thomas Preud'homme Date: Thu, 20 Aug 2020 19:41:43 +0000 (+0100) Subject: [Test][FileCheck] Fix use of undef var X-Git-Tag: llvmorg-13-init~1633 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c0cea2d9b8ae4dc47f7737e47a621ddcb9cb57cf;p=platform%2Fupstream%2Fllvm.git [Test][FileCheck] Fix use of undef var The test related to directives with prefix NUMEXPR-CONSTRAINT-NOMATCH refers to the numeric variable UNSI which is defined by a directive with prefix CHECK not enabled on the lit command-line. Rather than adding the prefix CHECK to the lit command-line, this commit defined variable UNSI in a new NUMEXPR-CONSTRAINT-NOMATCH prefixed directive. The directive needs to contain more than just the variable otherwise the error message from FileCheck is about the wrong line being matched. Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D93346 --- diff --git a/llvm/test/FileCheck/numeric-expression.txt b/llvm/test/FileCheck/numeric-expression.txt index 7969ca9..0f6c143 100644 --- a/llvm/test/FileCheck/numeric-expression.txt +++ b/llvm/test/FileCheck/numeric-expression.txt @@ -250,12 +250,14 @@ RUN: not FileCheck --check-prefix NUMEXPR-CONSTRAINT-NOMATCH --input-file %s %s RUN: | FileCheck --check-prefix NUMEXPR-CONSTRAINT-NOMATCH-MSG --strict-whitespace %s USE DEF FMT EXPL NO MATCH -12 +UNSI=11 +UNSI: 12 NUMEXPR-CONSTRAINT-NOMATCH-LABEL: USE DEF FMT EXPL NO MATCH -NUMEXPR-CONSTRAINT-NOMATCH-NEXT: [[#==UNSI]] +NUMEXPR-CONSTRAINT-NOMATCH-NEXT: UNSI=[[#UNSI:]] +NUMEXPR-CONSTRAINT-NOMATCH-NEXT: UNSI: [[#==UNSI]] NUMEXPR-CONSTRAINT-NOMATCH-MSG: numeric-expression.txt:[[#@LINE-1]]:34: error: {{N}}UMEXPR-CONSTRAINT-NOMATCH-NEXT: expected string not found in input -NUMEXPR-CONSTRAINT-NOMATCH-MSG-NEXT: {{N}}UMEXPR-CONSTRAINT-NOMATCH-NEXT: {{\[\[#==UNSI\]\]}} -NUMEXPR-CONSTRAINT-NOMATCH-MSG-NEXT: {{^}} ^{{$}} +NUMEXPR-CONSTRAINT-NOMATCH-MSG-NEXT: {{N}}UMEXPR-CONSTRAINT-NOMATCH-NEXT: UNSI: {{\[\[#==UNSI\]\]}} +NUMEXPR-CONSTRAINT-NOMATCH-MSG-NEXT: {{^}} ^{{$}} ; Empty numeric expression with matching constraint. RUN: %ProtectFileCheckOutput \