From: Axel Lin <axel.lin@ingics.com>
Date: Sun, 23 Jun 2013 07:50:07 +0000 (+0800)
Subject: of/irq: Avoid calling list_first_entry() for empty list
X-Git-Tag: v3.11-rc3~21^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c0cdfaa0a5e7a346ac2f661f63f543cdc5f7cbbe;p=profile%2Fivi%2Fkernel-x86-ivi.git

of/irq: Avoid calling list_first_entry() for empty list

list_first_entry() expects the list is not empty, we need to check if list is
empty before calling list_first_entry(). Thus use list_first_entry_or_null()
instead of list_first_entry().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
---

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index a3c1c5a..5c645c7 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -482,8 +482,9 @@ void __init of_irq_init(const struct of_device_id *matches)
 		}
 
 		/* Get the next pending parent that might have children */
-		desc = list_first_entry(&intc_parent_list, typeof(*desc), list);
-		if (list_empty(&intc_parent_list) || !desc) {
+		desc = list_first_entry_or_null(&intc_parent_list,
+						typeof(*desc), list);
+		if (!desc) {
 			pr_err("of_irq_init: children remain, but no parents\n");
 			break;
 		}