From: Dan Carpenter Date: Wed, 10 Jun 2020 08:58:52 +0000 (+0300) Subject: vhost_vdpa: Fix potential underflow in vhost_vdpa_mmap() X-Git-Tag: v5.15~3516^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c09cc2c319863f620caf5e723db496eed55f7c7f;p=platform%2Fkernel%2Flinux-starfive.git vhost_vdpa: Fix potential underflow in vhost_vdpa_mmap() The "vma->vm_pgoff" variable is an unsigned long so if it's larger than INT_MAX then "index" can be negative leading to an underflow. Fix this by changing the type of "index" to "unsigned long". Fixes: ddd89d0a059d ("vhost_vdpa: support doorbell mapping via mmap") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20200610085852.GB5439@mwanda Signed-off-by: Michael S. Tsirkin --- diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 7580e34..a54b60d 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -818,7 +818,7 @@ static int vhost_vdpa_mmap(struct file *file, struct vm_area_struct *vma) struct vdpa_device *vdpa = v->vdpa; const struct vdpa_config_ops *ops = vdpa->config; struct vdpa_notification_area notify; - int index = vma->vm_pgoff; + unsigned long index = vma->vm_pgoff; if (vma->vm_end - vma->vm_start != PAGE_SIZE) return -EINVAL;