From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 4 Feb 2019 15:35:10 +0000 (+0100)
Subject: ALSA: ppc: Drop superfluous PCM preallocation error checks
X-Git-Tag: v5.4-rc1~1151^2~71^2~16
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c025672290d7a21df00d9b89ccc422a94eda5671;p=platform%2Fkernel%2Flinux-rpi.git

ALSA: ppc: Drop superfluous PCM preallocation error checks

snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
index abe031c..521236e 100644
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -1024,15 +1024,11 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
 
 	the_card.pcm->info_flags = SNDRV_PCM_INFO_NONINTERLEAVED;
 	/* pre-alloc PCM DMA buffer*/
-	ret = snd_pcm_lib_preallocate_pages_for_all(the_card.pcm,
+	snd_pcm_lib_preallocate_pages_for_all(the_card.pcm,
 					SNDRV_DMA_TYPE_DEV,
 					&dev->core,
 					SND_PS3_PCM_PREALLOC_SIZE,
 					SND_PS3_PCM_PREALLOC_SIZE);
-	if (ret < 0) {
-		pr_info("%s: prealloc failed\n", __func__);
-		goto clean_card;
-	}
 
 	/*
 	 * allocate null buffer