From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 11 Oct 2018 07:59:41 +0000 (+0300)
Subject: staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()
X-Git-Tag: v5.4-rc1~2324^2~52
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c00e1d09e3053c6af6a7f6d405b5b455f247d5d4;p=platform%2Fkernel%2Flinux-rpi.git

staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()

We need to unlock before returning on this error path.

Fixes: 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index 042e4f3..78a9c9b 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -424,6 +424,7 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
 	/* pinning is done in prepare/cleanup framebuffer */
 	src = vbox_bo_kmap(bo);
 	if (IS_ERR(src)) {
+		mutex_unlock(&vbox->hw_mutex);
 		DRM_WARN("Could not kmap cursor bo, skipping update\n");
 		return;
 	}