From: Daniel Hahler <git@thequod.de>
Date: Fri, 12 Sep 2014 15:13:43 +0000 (+0200)
Subject: Document skipping in PreparedRequest; followup to #2222
X-Git-Tag: v2.4.2~13^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bff8b91638586a8269f79f1bac6e82921702e5b3;p=services%2Fpython-requests.git

Document skipping in PreparedRequest; followup to #2222
---

diff --git a/requests/models.py b/requests/models.py
index 03ff627..bbf08c8 100644
--- a/requests/models.py
+++ b/requests/models.py
@@ -334,7 +334,9 @@ class PreparedRequest(RequestEncodingMixin, RequestHooksMixin):
         except UnicodeDecodeError:
             pass
 
-        # Don't do any URL preparation for oddball schemes
+        # Don't do any URL preparation for non-HTTP schemes like `mailto`,
+        # `data` etc to work around exceptions from `url_parse`, which
+        # handles RFC 3986 only.
         if ':' in url and not url.lower().startswith('http'):
             self.url = url
             return
diff --git a/test_requests.py b/test_requests.py
index 9f75a9d..4fccc34 100755
--- a/test_requests.py
+++ b/test_requests.py
@@ -922,7 +922,7 @@ class RequestsTestCase(unittest.TestCase):
 
         assert p.headers['Content-Length'] == length
 
-    def test_oddball_schemes_dont_check_URLs(self):
+    def test_nonhttp_schemes_dont_check_URLs(self):
         test_urls = (
             'data:image/gif;base64,R0lGODlhAQABAHAAACH5BAUAAAAALAAAAAABAAEAAAICRAEAOw==',
             'file:///etc/passwd',