From: Richard Guy Briggs <rgb@redhat.com>
Date: Wed, 23 Apr 2014 01:31:53 +0000 (-0400)
Subject: netlink: simplify nfnetlink_bind
X-Git-Tag: v3.16-rc1~27^2~340^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bfe4bc71c64a34813a7bde0ad4d28486679ac3fe;p=platform%2Fkernel%2Flinux-exynos.git

netlink: simplify nfnetlink_bind

Remove duplicity and simplify code flow by moving the rcu_read_unlock() above
the condition and let the flow control exit naturally at the end of the
function.

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
index e8138da..0df800a 100644
--- a/net/netfilter/nfnetlink.c
+++ b/net/netfilter/nfnetlink.c
@@ -407,12 +407,9 @@ static void nfnetlink_bind(int group)
 
 	rcu_read_lock();
 	ss = nfnetlink_get_subsys(type);
-	if (!ss) {
-		rcu_read_unlock();
-		request_module("nfnetlink-subsys-%d", type);
-		return;
-	}
 	rcu_read_unlock();
+	if (!ss)
+		request_module("nfnetlink-subsys-%d", type);
 }
 #endif