From: Mathieu Duponchelle <mathieu@centricular.com>
Date: Thu, 16 Aug 2018 16:55:29 +0000 (+0200)
Subject: mp4 robust muxing: improve documentation and logging
X-Git-Tag: 1.19.3~509^2~1454
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bfcddb71250bef9ffd5b4d333589ba4385fea86e;p=platform%2Fupstream%2Fgstreamer.git

mp4 robust muxing: improve documentation and logging
---

diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c
index 4733bb6..cf8148d 100644
--- a/gst/isomp4/gstqtmux.c
+++ b/gst/isomp4/gstqtmux.c
@@ -2968,6 +2968,10 @@ gst_qt_mux_start_file (GstQTMux * qtmux)
             (NULL));
         return GST_FLOW_ERROR;
       }
+      if (qtmux->reserved_moov_update_period == GST_CLOCK_TIME_NONE) {
+        GST_WARNING_OBJECT (qtmux,
+            "Robust muxing requires reserved-moov-update-period to be set");
+      }
       break;
     case GST_QT_MUX_MODE_FAST_START:
     case GST_QT_MUX_MODE_FRAGMENTED_STREAMABLE:
diff --git a/gst/multifile/gstsplitmuxsink.c b/gst/multifile/gstsplitmuxsink.c
index 260e8e3..0568c65 100644
--- a/gst/multifile/gstsplitmuxsink.c
+++ b/gst/multifile/gstsplitmuxsink.c
@@ -338,7 +338,8 @@ gst_splitmux_sink_class_init (GstSplitMuxSinkClass * klass)
           "reserved-duration-remaining properties and use them if so. "
           "(Only present on qtmux and mp4mux for now). splitmuxsink may then also "
           " create new fragments if the reserved header space is about to overflow. "
-          "Note this does not set reserved-moov-update-period - apps should do that manually",
+          "Note that for mp4mux and qtmux, reserved-moov-update-period must be set "
+          "manually by the app to a non-zero value for robust muxing to have an effect.",
           DEFAULT_USE_ROBUST_MUXING,
           G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));