From: Colin Ian King Date: Fri, 8 Sep 2017 14:13:33 +0000 (+0100) Subject: drm/amdkfd: check for null dev to avoid a null pointer dereference X-Git-Tag: v4.14-rc3~17^2~3^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bfaa1ce809bbcd12b1399409ab1dbf0cdaba6e27;p=platform%2Fkernel%2Flinux-rpi.git drm/amdkfd: check for null dev to avoid a null pointer dereference The call to kfd_device_by_id can potentially return null, so check that dev is null and return with -EINVAL to avoid a null pointer dereference. Detected by CoverityScan CID#1454629 ("Dereference null return value") Fixes: 5d71dbc3a588 ("drm/amdkfd: Implement image tiling mode support v2") Signed-off-by: Colin Ian King Signed-off-by: Oded Gabbay --- diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index e4a8c2e..660b3fb 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -892,6 +892,8 @@ static int kfd_ioctl_get_tile_config(struct file *filep, int err = 0; dev = kfd_device_by_id(args->gpu_id); + if (!dev) + return -EINVAL; dev->kfd2kgd->get_tile_config(dev->kgd, &config);