From: Sachin Prabhu Date: Fri, 13 Apr 2012 13:04:32 +0000 (+0100) Subject: Fix number parsing in cifs_parse_mount_options X-Git-Tag: upstream/snapshot3+hdmi~7672^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bfa890a3cdeed29eef53d54cd7f80cec0fd46b11;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git Fix number parsing in cifs_parse_mount_options The function kstrtoul() used to parse number strings in the mount option parser is set to expect a base 10 number . This treats the octal numbers passed for mount options such as file_mode as base10 numbers leading to incorrect behavior. Change the 'base' argument passed to kstrtoul from 10 to 0 to allow it to auto-detect the base of the number passed. Signed-off-by: Sachin Prabhu Acked-by: Jeff Layton Reported-by: Chris Clayton Signed-off-by: Steve French --- diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 6a86f3d..f31dc9a 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -1123,7 +1123,7 @@ static int get_option_ul(substring_t args[], unsigned long *option) string = match_strdup(args); if (string == NULL) return -ENOMEM; - rc = kstrtoul(string, 10, option); + rc = kstrtoul(string, 0, option); kfree(string); return rc;