From: Axel Lin <axel.lin@ingics.com>
Date: Thu, 29 Sep 2016 02:13:28 +0000 (+0800)
Subject: PM / devfreq: Add proper locking around list_del()
X-Git-Tag: accepted/tizen/4.0/unified/20170920.081531~78
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bf9f266875130509a7bd807af0515a515180cd0b;p=platform%2Fkernel%2Flinux-exynos.git

PM / devfreq: Add proper locking around list_del()

Use devfreq_list_lock around list_del() to prevent list corruption.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 478006b..66d3c718 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -594,17 +594,19 @@ struct devfreq *devfreq_add_device(struct device *dev,
 	if (devfreq->governor)
 		err = devfreq->governor->event_handler(devfreq,
 					DEVFREQ_GOV_START, NULL);
-	mutex_unlock(&devfreq_list_lock);
 	if (err) {
 		dev_err(dev, "%s: Unable to start governor for the device\n",
 			__func__);
 		goto err_init;
 	}
+	mutex_unlock(&devfreq_list_lock);
 
 	return devfreq;
 
 err_init:
 	list_del(&devfreq->node);
+	mutex_unlock(&devfreq_list_lock);
+
 	device_unregister(&devfreq->dev);
 err_out:
 	return ERR_PTR(err);