From: Jamie Iles Date: Thu, 4 Aug 2011 08:39:31 +0000 (+0100) Subject: ARM: 7010/1: mm: fix invalid loop for poison_init_mem X-Git-Tag: v3.1-rc2~29^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bf912d99e94cd1f43a7decce2e9b79a3ca7f2418;p=platform%2Fupstream%2Fkernel-adaptation-pc.git ARM: 7010/1: mm: fix invalid loop for poison_init_mem poison_init_mem() used a loop of: while ((count = count - 4)) which has 2 problems - an off by one error so that we do one less word than we should, and the other is that if count == 0 then we loop forever and poison too much. On a platform with HAVE_TCM=y but nothing in the TCM's, this caused corruption and the platform failed to boot. Acked-by: Stephen Boyd Acked-by: Nicolas Pitre Signed-off-by: Jamie Iles Signed-off-by: Russell King --- diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 2fee782..91bca35 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -441,7 +441,7 @@ static inline int free_area(unsigned long pfn, unsigned long end, char *s) static inline void poison_init_mem(void *s, size_t count) { u32 *p = (u32 *)s; - while ((count = count - 4)) + for (; count != 0; count -= 4) *p++ = 0xe7fddef0; }