From: Sebastian Dröge <sebastian@centricular.com>
Date: Fri, 29 Apr 2022 16:08:46 +0000 (+0300)
Subject: interlace: Also handle a missing "interlace-mode" field as progressive
X-Git-Tag: 1.22.0~1706
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bf89c80d74f424e54a401243513781c73d0a6e6d;p=platform%2Fupstream%2Fgstreamer.git

interlace: Also handle a missing "interlace-mode" field as progressive

Otherwise caps negotiation will fail in situations that are supposed
to work, like:

  "video/x-raw,framerate=(fraction)60/1" ! interlace field-pattern=0 ! "video/x-raw,framerate=(fraction)30/1"

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2335>
---

diff --git a/subprojects/gst-plugins-bad/gst/interlace/gstinterlace.c b/subprojects/gst-plugins-bad/gst/interlace/gstinterlace.c
index bf7cbfe..ca22e74 100644
--- a/subprojects/gst-plugins-bad/gst/interlace/gstinterlace.c
+++ b/subprojects/gst-plugins-bad/gst/interlace/gstinterlace.c
@@ -775,7 +775,8 @@ gst_interlace_caps_double_framerate (GstCaps * caps, gboolean half,
     interlace_mode = gst_structure_get_string (s, "interlace-mode");
     /* Do not double the framerate for interlaced - we will either passthrough
      * or fail to negotiate */
-    if (skip_progressive && (g_strcmp0 (interlace_mode, "progressive") != 0))
+    if (skip_progressive && (interlace_mode
+            && g_strcmp0 (interlace_mode, "progressive") != 0))
       continue;
 
     if (G_VALUE_TYPE (val) == GST_TYPE_FRACTION) {