From: Uros Bizjak Date: Sun, 15 Jan 2012 18:03:46 +0000 (+0100) Subject: re PR rtl-optimization/51821 (64bit > 32bit conversion produces incorrect results... X-Git-Tag: upstream/12.2.0~78574 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bf63ef6c22e8d8f972e76dad2b75ef509ddbc062;p=platform%2Fupstream%2Fgcc.git re PR rtl-optimization/51821 (64bit > 32bit conversion produces incorrect results with optimizations) PR rtl-optimization/51821 * recog.c (peep2_find_free_register): Determine clobbered registers from insn pattern. testsuite/ChangeLog: PR rtl-optimization/51821 * gcc.dg/pr51821.c: New test. From-SVN: r183194 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 601daee..b74e609 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2012-01-15 Uros Bizjak + + PR rtl-optimization/51821 + * recog.c (peep2_find_free_register): Determine clobbered registers + from insn pattern. + 2012-01-14 Denis Chertykov PR target/50925 diff --git a/gcc/recog.c b/gcc/recog.c index 19f00b1..8f04179 100644 --- a/gcc/recog.c +++ b/gcc/recog.c @@ -3038,6 +3038,7 @@ peep2_find_free_register (int from, int to, const char *class_str, static int search_ofs; enum reg_class cl; HARD_REG_SET live; + df_ref *def_rec; int i; gcc_assert (from < MAX_INSNS_PER_PEEP2 + 1); @@ -3051,12 +3052,14 @@ peep2_find_free_register (int from, int to, const char *class_str, while (from != to) { - HARD_REG_SET this_live; + gcc_assert (peep2_insn_data[from].insn != NULL_RTX); + + /* Don't use registers set or clobbered by the insn. */ + for (def_rec = DF_INSN_DEFS (peep2_insn_data[from].insn); + *def_rec; def_rec++) + SET_HARD_REG_BIT (live, DF_REF_REGNO (*def_rec)); from = peep2_buf_position (from + 1); - gcc_assert (peep2_insn_data[from].insn != NULL_RTX); - REG_SET_TO_HARD_REG_SET (this_live, peep2_insn_data[from].live_before); - IOR_HARD_REG_SET (live, this_live); } cl = (class_str[0] == 'r' ? GENERAL_REGS diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 015c507..8bf1c29 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2012-01-15 Uros Bizjak + + PR rtl-optimization/51821 + * gcc.dg/pr51821.c: New test. + 2012-01-15 Andreas Schwab * gcc.dg/torture/pr8081.c: Fix char signedness assumption. diff --git a/gcc/testsuite/gcc.dg/pr51821.c b/gcc/testsuite/gcc.dg/pr51821.c new file mode 100644 index 0000000..e7ba409 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr51821.c @@ -0,0 +1,24 @@ +/* { dg-do run } */ +/* { dg-options "-O2 -msse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-require-effective-target sse_runtime { target { i?86-*-* x86_64-*-* } } } */ + +extern void abort (void); + +unsigned int __attribute__((noinline)) +test (int shift_size) +{ + unsigned long long res = ~0; + + return res << shift_size; +} + +int +main () +{ + int dst = 32; + + if (test (dst) != 0) + abort (); + + return 0; +}