From: Heesub Shin Date: Sun, 19 Mar 2017 05:37:14 +0000 (+0900) Subject: s5j/sflash: remove all unnecessary code lines X-Git-Tag: 1.1_Public_Release~614^2~283 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bece3cff3cac8353c77ba5c21b7ccd1535b707e8;p=rtos%2Ftinyara.git s5j/sflash: remove all unnecessary code lines This commit cleans up unnecessary code lines that are not in use. It seems to change extensively, but does not make any functional difference. Change-Id: I37e2c742591b089735c88ebcc4e7bd9522b9ddec Signed-off-by: Heesub Shin --- diff --git a/os/arch/arm/src/s5j/s5j_sflash.c b/os/arch/arm/src/s5j/s5j_sflash.c index e181cbd..a8db83b 100644 --- a/os/arch/arm/src/s5j/s5j_sflash.c +++ b/os/arch/arm/src/s5j/s5j_sflash.c @@ -53,815 +53,25 @@ /**************************************************************************** * Included Files ****************************************************************************/ -#include +#include + #include -#include -#include -#include -#include -#include -#include -#include +#include #include #include "up_arch.h" +#include "soc/s5jt200_memorymap.h" #include "cache.h" -#include #include "s5j_qspi.h" /**************************************************************************** * Pre-processor Definitions ****************************************************************************/ #define S5J_SFLASH_MAPPED_ADDR (CONFIG_S5J_FLASH_BASE) -#define S5J_SFLASH_USE_DIRECT_RW - -#define SFLASH_SECTOR_SIZE (4096) -#define SECTOR_ALIGN_SIZE(x) (((x)/SFLASH_SECTOR_SIZE)*SFLASH_SECTOR_SIZE) - -#define MIN(a, b) ((a) > (b) ? (b) : (a)) - -/**************************************************************************** - * Private Types - ****************************************************************************/ -/* Command definitions */ -enum s5j_sflash_command_e { - SFLASH_WRITE_STATUS_REGISTER = 0x01, /* WRSR */ - SFLASH_WRITE = 0x02, - SFLASH_READ = 0x03, - SFLASH_WRITE_DISABLE = 0x04, /* WRDI */ - SFLASH_READ_STATUS_REGISTER = 0x05, /* RDSR */ - SFLASH_WRITE_ENABLE = 0x06, /* WREN */ - SFLASH_SECTOR_ERASE = 0x20, /* SE */ - SFLASH_READ_STATUS_REGISTER2 = 0x35, /* RDSR-2 - Winbond only */ - SFLASH_BLOCK_ERASE_MID = 0x52, /* SE */ - SFLASH_BLOCK_ERASE_LARGE = 0xD8, /* SE */ - SFLASH_READ_ID1 = 0x90, /* data size varies */ - SFLASH_READ_ID2 = 0xAB, /* data size varies */ - SFLASH_READ_JEDEC_ID = 0x9F, /* RDID */ - SFLASH_CHIP_ERASE1 = 0x60, /* CE */ - SFLASH_CHIP_ERASE2 = 0xC7, /* CE */ - SFLASH_DUMMY = 0xA5, /* Dummy */ -}; - -struct s5j_sflash_dev_s { - struct spi_dev_s spi_dev; - uint32_t addr; - sem_t sem_excl; - void *priv; -}; - -/**************************************************************************** - * Private Function Prototypes - ****************************************************************************/ -static int s5j_sflash_init(struct s5j_sflash_dev_s *dev); -static int s5j_sflash_write_enable(struct s5j_sflash_dev_s *dev); -static int s5j_sflash_lock(FAR struct spi_dev_s *spidev, bool lock); -static void s5j_sflash_select(FAR struct spi_dev_s *spidev, - enum spi_dev_e devid, bool selected); -static uint32_t s5j_sflash_setfrequency(FAR struct spi_dev_s *spidev, - uint32_t frequency); -static int s5j_sflash_setmode(FAR struct spi_dev_s *spidev, - enum spi_mode_e mode); -static int s5j_sflash_setbits(FAR struct spi_dev_s *spidev, int nbits); -#ifdef CONFIG_SPI_HWFEATURES -static int s5j_sflash_hwfeatures(FAR struct spi_dev_s *spidev, - spi_hwfeatures_t features); -#endif -static uint16_t s5j_sflash_send(FAR struct spi_dev_s *spidev, uint16_t wd); -static void s5j_sflash_exchange(FAR struct spi_dev_s *spidev, - FAR const void *txbuffer, FAR void *rxbuffer, size_t nwords); -static void s5j_sflash_sndblock(FAR struct spi_dev_s *spidev, - FAR const void *buffer, size_t nwords); -static void s5j_sflash_recvblock(FAR struct spi_dev_s *spidev, - FAR void *buffer, size_t nwords); - -/**************************************************************************** - * Private Data - ****************************************************************************/ -static FAR const struct spi_ops_s s5j_spi_ops = { - .lock = s5j_sflash_lock, - .select = s5j_sflash_select, - .setfrequency = s5j_sflash_setfrequency, - .setmode = s5j_sflash_setmode, - .setbits = s5j_sflash_setbits, -#ifdef CONFIG_SPI_HWFEATURES - .hwfeatures = s5j_sflash_hwfeatures, -#endif - .status = NULL, -#ifdef CONFIG_SPI_CMDDATA - .cmddata = NULL, -#endif - .send = s5j_sflash_send, -#ifdef CONFIG_SPI_EXCHANGE - .exchange = s5j_sflash_exchange, -#else - .sndblock = s5j_sflash_sndblock, - .recvblock = s5j_sflash_recvblock, -#endif - .registercallback = NULL -}; - -static struct s5j_sflash_dev_s sflashdev = { - .spi_dev = { - .ops = &s5j_spi_ops, - }, - .sem_excl = SEM_INITIALIZER(1), - .priv = NULL, -}; - -/**************************************************************************** - * Public Data - ****************************************************************************/ - -/**************************************************************************** - * Private Functions - ****************************************************************************/ - -/**************************************************************************** - * Name: s5j_sflash_sem_post - * - * Description: - * Release the mutual exclusion semaphore - * - * Input Parameters: - * dev - pointer to spi dev structure - * - * Returned Value: - * OK - * - ****************************************************************************/ -static inline void s5j_sflash_sem_post(struct s5j_sflash_dev_s *dev) -{ - sem_post(&dev->sem_excl); -} - -/**************************************************************************** - * Name: s5j_sflash_sem_init - * - * Description: - * Initialize semaphores - * - * Input Parameters: - * dev - pointer to spi dev structure - * - * Returned Value: - * OK - * - ****************************************************************************/ -static inline void s5j_sflash_sem_init(struct s5j_sflash_dev_s *dev) -{ - sem_init(&dev->sem_excl, 0, 1); -} - -/**************************************************************************** - * Name: s5j_sflash_sem_wait - * - * Description: - * Take the exclusive access, waiting as necessary - * - * Input Parameters: - * dev - pointer to spi dev structure - * - * Returned Value: - * OK - * - ****************************************************************************/ -static inline void s5j_sflash_sem_wait(struct s5j_sflash_dev_s *dev) -{ - while (sem_wait(&dev->sem_excl) != OK) { - ASSERT(errno == EINTR); - } -} - -/**************************************************************************** - * Name: s5j_sflash_erase - * - * Description: - * Flash Erase - * - * Input Parameters: - * dev - pointer to spi dev structure - * cmd - erase command - * addr - erase start address - * - * Returned Value: - * OK - * - ****************************************************************************/ -static int s5j_sflash_erase(struct s5j_sflash_dev_s *dev, uint8_t cmd, - uint32_t addr) -{ - int ret; -#ifdef CONFIG_S5J_FLASH_ONLY_ALLOW_SUBSECTOR - uint32_t i; -#endif - uint32_t val; - int size = 0; - -#ifdef S5J_SFLASH_USE_DIRECT_RW - /* debug code */ - if (dev == NULL) { - dev = &sflashdev; - } -#endif - - s5j_qspi_disable_wp(); - - do { - ret = s5j_sflash_write_enable(dev); - if (OK != ret) { - usleep(100); - } - } while (OK != ret); - - switch (cmd) { - case SFLASH_CHIP_ERASE1: - val = getreg32(rSF_CON) | (1 << 31) | (1 << 15); - putreg32(val, rSF_CON); - addr = 0; - Outp8(rCE, QSPI_DUMMY_DATA); - break; - - case SFLASH_CHIP_ERASE2: - addr = 0; - Outp8(rCE, QSPI_DUMMY_DATA); - break; - - case SFLASH_SECTOR_ERASE: - Outp32(rERASE_ADDRESS, addr); - Outp8(rSE, QSPI_DUMMY_DATA); - size = 4096; /* Sub-sector size */ - break; - - case SFLASH_BLOCK_ERASE_LARGE: - size = 65536; /* block size */ -#ifdef CONFIG_S5J_FLASH_ONLY_ALLOW_SUBSECTOR - for (i = 0; i < 16; i++) { - Outp32(rERASE_ADDRESS, addr + i * 4096); - Outp8(rSE, QSPI_DUMMY_DATA); - - while (getreg8(rRDSR) & 0x1) ; - pthread_yield(); - } -#else - SetBits(rCOMMAND2, 16, 0xFF, COMMAND_ERASE_64KB); - Outp32(rERASE_ADDRESS, addr); - Outp8(rBE, QSPI_DUMMY_DATA); -#endif - break; - - default: - break; - } - - while (getreg8(rRDSR) & 0x1) ; - - s5j_qspi_enable_wp(); - - if (cmd != SFLASH_CHIP_ERASE1) { - arch_invalidate_dcache(addr + S5J_SFLASH_MAPPED_ADDR, - (addr + S5J_SFLASH_MAPPED_ADDR + size)); - } - - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_write_enable - * - * Description: - * Enable flash write operation - * - * Input Parameters: - * dev - pointer to spi dev structure - * - * Returned Value: - * OK - * - ****************************************************************************/ -static int s5j_sflash_write_enable(struct s5j_sflash_dev_s *dev) -{ - SetBits(rCOMMAND4, 8, 0xFF, 0x06); - - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_write_disable - * - * Description: - * Disable flash write operation - * - * Input Parameters: - * dev - pointer to spi dev structure - * - * Returned Value: - * OK - * - ****************************************************************************/ -static int s5j_sflash_write_disable(struct s5j_sflash_dev_s *dev) -{ - SetBits(rCOMMAND4, 8, 0xFF, 0x04); - - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_read - * - * Description: - * Read data from flash. - * - * Input Parameters: - * dev - pointer to spi dev structure - * addr - Start address - * buf - pointer to buffer for data to read - * size - number of bytes to read - * - * Returned Value: - * OK - * - ****************************************************************************/ -static int s5j_sflash_read(struct s5j_sflash_dev_s *dev, uint32_t addr, - uint8_t *buf, uint32_t size) -{ - int32_t i; - int32_t readsize; - uint32_t offset; - - i = 0; - -#ifdef S5J_SFLASH_USE_DIRECT_RW - /* debug code */ - - if (dev == NULL) { - dev = &sflashdev; - } -#endif - - /* it avoid to conflict smartfs read and SSS f/w write */ - s5j_qspi_take_sem(); - - fvdbg("addr 0x%x, size %d\n", addr, size); - while (size != 0) { - /* first align */ - offset = addr % SFLASH_SECTOR_SIZE; - readsize = MIN(SFLASH_SECTOR_SIZE - offset, size); - - memcpy((void *)(buf + i), - (void *)(addr + S5J_SFLASH_MAPPED_ADDR), - readsize); - - addr += readsize; - i += readsize; - size -= readsize; - } - - s5j_qspi_release_sem(); - - fvdbg("buf[%d]\n", *buf); - - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_write - * - * Description: - * Write data. - * - * Input Parameters: - * dev - pointer to spi dev structure - * addr - Start address - * buf - pointer to buffer for data to write - * size - number of bytes to write - * - * Returned Value: - * OK - * - ****************************************************************************/ -static int s5j_sflash_write(struct s5j_sflash_dev_s *dev, uint32_t addr, - uint8_t *buf, uint32_t size) -{ - int32_t i; - int32_t readsize; - uint32_t offset; - - i = 0; - - /* write is directly called from nshlib, so may allow it */ - -#ifdef S5J_SFLASH_USE_DIRECT_RW - /* debug code */ - - if (dev == NULL) { - dev = &sflashdev; - } -#endif - - while (size != 0) { - /* first align */ - - offset = addr % SFLASH_SECTOR_SIZE; - readsize = MIN(SFLASH_SECTOR_SIZE - offset, size); - s5j_qspi_disable_wp(); - memcpy((void *)(addr + S5J_SFLASH_MAPPED_ADDR), - (void *)(buf + i), readsize); - arch_flush_dcache(addr + S5J_SFLASH_MAPPED_ADDR, - (addr + S5J_SFLASH_MAPPED_ADDR + readsize)); - s5j_qspi_enable_wp(); - addr += readsize; - i += readsize; - size -= readsize; - - /* check write in progress */ - while (getreg8(rRDSR) & 0x1) ; - pthread_yield(); - } - - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_init - * - * Description: - * initialize sflash controller. - * - * Input Parameters: - * spidev - pointer to spi dev structure - * - * Returned Value: - * OK - * - ****************************************************************************/ -static int s5j_sflash_init(struct s5j_sflash_dev_s *dev) -{ - /* initialize mutex */ - s5j_sflash_sem_init(dev); - - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_lock - * - * Description: - * Support Lock/Unlock. This function s a part of spi_ops. - * - * Input Parameters: - * spidev - pointer to spi dev structure - * lock - true, locks access; false, release access - * - * Returned Value: - * OK - * - ****************************************************************************/ -static int s5j_sflash_lock(FAR struct spi_dev_s *spidev, bool lock) -{ - struct s5j_sflash_dev_s *dev; - - dev = (struct s5j_sflash_dev_s *)spidev; - - if (lock) { - s5j_sflash_sem_wait(dev); - } else { - s5j_sflash_sem_post(dev); - } - - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_select - * - * Description: - * Support SPI CS. But, the S5J only 1 sflash. We don't necessary. - * This function is a part of spi_ops. Dummy Function - * - ****************************************************************************/ -static void s5j_sflash_select(FAR struct spi_dev_s *spidev, - enum spi_dev_e devid, bool selected) -{ -} - -/**************************************************************************** - * Name: s5j_sflash_setfrequency - * - * Description: - * Support changing frequency. Dummy function. - * - ****************************************************************************/ -static uint32_t s5j_sflash_setfrequency(FAR struct spi_dev_s *spidev, - uint32_t frequency) -{ - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_setmode - * - * Description: - * Support changing mode(CPHA/CPOL). Dummy function. - * - ****************************************************************************/ -static int s5j_sflash_setmode(FAR struct spi_dev_s *spidev, - enum spi_mode_e mode) -{ - return OK; -} - -/**************************************************************************** - * Name: s5j_sflash_setbits - * - * Description: - * Support changing 1/4Bit. Dummy function. - * - ****************************************************************************/ -static int s5j_sflash_setbits(FAR struct spi_dev_s *spidev, int nbits) -{ - return OK; -} - -#ifdef CONFIG_SPI_HWFEATURES -/**************************************************************************** - * Name: s5j_sflash_setbits - * - * Description: - * This function is a part of spi_ops. Dummy function. - * - ****************************************************************************/ -static int s5j_sflash_hwfeatures(FAR struct spi_dev_s *spidev, - spi_hwfeatures_t features) -{ - return OK; -} -#endif - -/**************************************************************************** - * Name: s5j_sflash_send - * - * Description: - * Send a slave address from upper-level driver to device. - * This function is a part of spi_ops. - * - * Input Parameters: - * spidev - pointer to spi dev structure - * wd - write data. Data is a command or erase addr. - * - * Returned Value: - * OK, or 0. - * - ****************************************************************************/ -static uint16_t s5j_sflash_send(FAR struct spi_dev_s *spidev, uint16_t wd) -{ - uint16_t data; - static uint32_t val; - static int32_t byteoffset; - static uint8_t addrmode; - static uint8_t erasemode; - static uint8_t cmd; - static int32_t addroffset; - struct s5j_sflash_dev_s *dev; - - data = 0; - - dev = (struct s5j_sflash_dev_s *)spidev; - - if (addrmode) { - dev->addr |= (wd << addroffset); - - addroffset -= 8; - - if (addroffset < 0) { - addrmode = 0; - - if (erasemode) { - erasemode = 0; - s5j_sflash_erase(dev, cmd, dev->addr); - } - } - - return OK; - } - - switch (wd) { - case SFLASH_READ_JEDEC_ID: - val = 0; - byteoffset = 24; - val = getreg32(rRDID); - /* mtd driver needs to Big endian */ - val = htonl(val); - break; - case SFLASH_READ_STATUS_REGISTER: - val = 0; - byteoffset = 0; - val = getreg8(rRDSR); - break; - case SFLASH_DUMMY: - /* need to touch flash ? */ - data = (val >> byteoffset) & 0xFF; - byteoffset -= 8; - break; - case SFLASH_READ: - addrmode = 1; - addroffset = 16; - dev->addr = 0; - break; - case SFLASH_WRITE: - addrmode = 1; - addroffset = 16; - dev->addr = 0; - break; - case SFLASH_WRITE_ENABLE: - s5j_sflash_write_enable(dev); - break; - case SFLASH_CHIP_ERASE1: - case SFLASH_CHIP_ERASE2: - s5j_sflash_erase(dev, SFLASH_CHIP_ERASE1, 0); - break; - case SFLASH_SECTOR_ERASE: - case SFLASH_BLOCK_ERASE_LARGE: - addrmode = 1; - erasemode = 1; - addroffset = 16; - dev->addr = 0; - cmd = wd; - break; - default: - break; - } - - return data; -} - -/**************************************************************************** - * Name: s5j_sflash_exchange - * - * Description: - * Send data from upper-level driver to device. - * This function is a part of spi_ops. - * - * Input Parameters: - * spidev - pointer to spi dev structure - * txbuffer - pointer to buffer with data to send - * rxbuffer - pointer to buffer for read data - * nwords - number of words (actually bytes) - * - * Returned Value: - * None - ****************************************************************************/ -static void s5j_sflash_exchange(FAR struct spi_dev_s *spidev, - FAR const void *txbuffer, FAR void *rxbuffer, size_t nwords) -{ - if (txbuffer) { - s5j_sflash_sndblock(spidev, txbuffer, nwords); - } else if (rxbuffer) { - s5j_sflash_recvblock(spidev, rxbuffer, nwords); - } else { - ASSERT(0); - } -} - -/**************************************************************************** - * Name: s5j_sflash_sndblock - * - * Description: - * Send data from upper-level driver to device. - * This function is a part of spi_ops. - * - * Input Parameters: - * spidev - pointer to spi dev structure - * buffer - pointer to buffer with data to send - * nwords - number of words (actually bytes) - * - * Returned Value: - * None - * - ****************************************************************************/ -static void s5j_sflash_sndblock(FAR struct spi_dev_s *spidev, - FAR const void *buffer, size_t nwords) -{ - struct s5j_sflash_dev_s *dev; - - dev = (struct s5j_sflash_dev_s *)spidev; - - /* it's not word, it's byte */ - s5j_sflash_write(dev, dev->addr, (uint8_t *) buffer, nwords); -} - -/**************************************************************************** - * Name: s5j_sflash_recvblock - * - * Description: - * Recv data from device to upper-level driver - * This function is a part of spi_ops. - * - * Input Parameters: - * spidev - pointer to spi dev structure - * buffer - pointer to buffer for read data - * nwords - number of words (actually bytes) - * - * Returned Value: - * None - * - ****************************************************************************/ -static void s5j_sflash_recvblock(FAR struct spi_dev_s *spidev, - FAR void *buffer, size_t nwords) -{ - struct s5j_sflash_dev_s *dev; - - dev = (struct s5j_sflash_dev_s *)spidev; - - /* it's not word, it's byte */ - s5j_sflash_read(dev, dev->addr, buffer, nwords); -} /**************************************************************************** * Public Functions ****************************************************************************/ - -/**************************************************************************** - * Name: up_spiflashinitialize - * - * Description: - * Initialize SPI port - * - * Input Parameters: - * None - * - * Returned Value: - * Valid SPI device structure reference on success; a NULL on failure - * - ****************************************************************************/ -FAR struct spi_dev_s *up_spiflashinitialize(void) -{ - s5j_sflash_init(&sflashdev); - - sflashdev.priv = NULL; - - return (FAR struct spi_dev_s *)&sflashdev; -} - -/**************************************************************************** - * Name: up_spiflashinitialized - * - * Description: - * Check is spi slash device is initialized. - * - * Input Parameters: - * None - * - * Returned Value: - * == 1, Initialized - * == 0, not initialized - * - ****************************************************************************/ -int up_spiflashinitialized(void) -{ - if (sflashdev.priv) { - return 1; - } - - return 0; -} - -/**************************************************************************** - * Name: update_spiflashmtd - * - * Description: - * Updates spiflash private field with mtd pointer value - * - * Input Parameters: - * mtd - pointer to mtd dev structure - * - * Returned Value: - * none - * - ****************************************************************************/ -void update_spiflashmtd(struct mtd_dev_s *mtd) -{ - sflashdev.priv = mtd; -} - -/**************************************************************************** - * Name: getspiflashmtd - * - * Description: - * Returns spi flash mtd structure pointer - * - * Input Parameters: - * None - * - * Returned Value: - * mtd dev structure pointer - * - ****************************************************************************/ -struct mtd_dev_s *getspiflashmtd(void) -{ - return (struct mtd_dev_s *)sflashdev.priv; -} - #ifdef CONFIG_MTD_PROGMEM static uint8_t s5j_sflash_read_status(void) {