From: Jordan Rupprecht <rupprecht@google.com>
Date: Wed, 20 Mar 2019 17:44:24 +0000 (+0000)
Subject: [Remarks] Fix mismatched delete due to missing virtual destructor
X-Git-Tag: llvmorg-10-init~9563
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=becd797a97847270df668b646da9d1d9e9853409;p=platform%2Fupstream%2Fllvm.git

[Remarks] Fix mismatched delete due to missing virtual destructor

This fixes an asan failure introduced in r356519.

llvm-svn: 356583
---

diff --git a/llvm/lib/Remarks/RemarkParserImpl.h b/llvm/lib/Remarks/RemarkParserImpl.h
index 6804657..b4c106b 100644
--- a/llvm/lib/Remarks/RemarkParserImpl.h
+++ b/llvm/lib/Remarks/RemarkParserImpl.h
@@ -19,6 +19,10 @@ namespace remarks {
 struct ParserImpl {
   enum class Kind { YAML };
 
+  explicit ParserImpl(Kind TheParserKind) : ParserKind(TheParserKind) {}
+  // Virtual destructor prevents mismatched deletes
+  virtual ~ParserImpl() {}
+
   // The parser kind. This is used as a tag to safely cast between
   // implementations.
   Kind ParserKind;