From: Jesper Juhl Date: Sun, 20 Jan 2013 22:14:43 +0000 (+0100) Subject: pcmcia: avoid static analysis complaint about use-after-free X-Git-Tag: upstream/snapshot3+hdmi~4414^2~144 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bec0b2ce8304bedf56935c44912716882a365adb;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git pcmcia: avoid static analysis complaint about use-after-free Coverity complains about a use after free for 'res1' and 'res2' since we use the value of the pointers in a 'dev_dbg()' after they have been freed. That's not really a problem, but it still seems cleaner to defer freeing until we are completely done with the pointers. Signed-off-by: Jesper Juhl Signed-off-by: Jiri Kosina --- diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index 9da9656..dcce10e 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c @@ -369,12 +369,12 @@ static int do_validate_mem(struct pcmcia_socket *s, } } - free_region(res2); - free_region(res1); - dev_dbg(&s->dev, "cs: memory probe 0x%06lx-0x%06lx: %p %p %u %u %u", base, base+size-1, res1, res2, ret, info1, info2); + free_region(res2); + free_region(res1); + if ((ret) || (info1 != info2) || (info1 == 0)) return -EINVAL;