From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 19 Jul 2016 20:42:22 +0000 (+0200)
Subject: of: Delete an unnecessary check before the function call "of_node_put"
X-Git-Tag: v4.14-rc1~2615^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=beab47d55b883e85bec7771a899ac791c6f92c80;p=platform%2Fkernel%2Flinux-rpi.git

of: Delete an unnecessary check before the function call "of_node_put"

The of_node_put() function tests whether its argument is NULL
and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 7792266..cb255a0 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1631,8 +1631,7 @@ static int __of_parse_phandle_with_args(const struct device_node *np,
 	 */
 
  err:
-	if (it.node)
-		of_node_put(it.node);
+	of_node_put(it.node);
 	return rc;
 }