From: Kees Cook <keescook@chromium.org>
Date: Wed, 28 Aug 2013 20:32:01 +0000 (+0200)
Subject: HID: check for NULL field when setting values
X-Git-Tag: v5.15~19417^2~1^7~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=be67b68d52fa28b9b721c47bb42068f0c1214855;p=platform%2Fkernel%2Flinux-starfive.git

HID: check for NULL field when setting values

Defensively check that the field to be worked on is not NULL.

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index ebf5781..dcd60eb 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1169,7 +1169,12 @@ EXPORT_SYMBOL_GPL(hid_alloc_report_buf);
 
 int hid_set_field(struct hid_field *field, unsigned offset, __s32 value)
 {
-	unsigned size = field->report_size;
+	unsigned size;
+
+	if (!field)
+		return -1;
+
+	size = field->report_size;
 
 	hid_dump_input(field->report->device, field->usage + offset, value);