From: Oliver Neukum <oliver@neukum.org>
Date: Wed, 28 Jan 2009 08:36:18 +0000 (+0100)
Subject: HID: fix reversed logic in disconnect testing of hiddev
X-Git-Tag: v3.12-rc1~16106^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=be5d0c837cf8e43458c5757be5df4837a2803d08;p=kernel%2Fkernel-generic.git

HID: fix reversed logic in disconnect testing of hiddev

The logic for testing for disconnection is reversed in an ioctl leading
to false reports of disconnection.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Tested-by: Folkert van Heusden <folkert@vanheusden.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index d73eea3..4940e4d 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 
 	case HIDIOCGSTRING:
 		mutex_lock(&hiddev->existancelock);
-		if (!hiddev->exist)
+		if (hiddev->exist)
 			r = hiddev_ioctl_string(hiddev, cmd, user_arg);
 		else
 			r = -ENODEV;