From: Haihao Xiang <haihao.xiang@intel.com>
Date: Tue, 29 Dec 2020 01:41:05 +0000 (+0800)
Subject: msdk: needn't close mfx session when failed
X-Git-Tag: 1.19.3~507^2~931
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bdff6f5e42843d3929162525d5e291b22c7f4f20;p=platform%2Fupstream%2Fgstreamer.git

msdk: needn't close mfx session when failed

Otherwise we will get double free issue because mfx session is closed in
finalize. See
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1867#note_739346
for the double free issue.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1916>
---

diff --git a/sys/msdk/gstmsdkcontext.c b/sys/msdk/gstmsdkcontext.c
index d921078..012efe6 100644
--- a/sys/msdk/gstmsdkcontext.c
+++ b/sys/msdk/gstmsdkcontext.c
@@ -207,7 +207,6 @@ gst_msdk_context_open (GstMsdkContext * context, gboolean hardware,
   return TRUE;
 
 failed:
-  msdk_close_session (priv->session);
   return FALSE;
 }