From: Marcel Holtmann Date: Wed, 30 Jul 2014 06:08:45 +0000 (+0200) Subject: Bluetooth: Fix sparse warning from HID new leds handling X-Git-Tag: v4.9.8~5959^2~12^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bdb9434664d026ea63ad086443160dd4ed347758;p=platform%2Fkernel%2Flinux-rpi3.git Bluetooth: Fix sparse warning from HID new leds handling The new leds bit handling produces this spares warning. CHECK net/bluetooth/hidp/core.c net/bluetooth/hidp/core.c:156:60: warning: dubious: x | !y Just fix it by doing an explicit x << 0 shift operation. Signed-off-by: Marcel Holtmann Signed-off-by: Johan Hedberg --- diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 8181ea4..6c7ecf1 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -154,7 +154,7 @@ static int hidp_input_event(struct input_dev *dev, unsigned int type, (!!test_bit(LED_COMPOSE, dev->led) << 3) | (!!test_bit(LED_SCROLLL, dev->led) << 2) | (!!test_bit(LED_CAPSL, dev->led) << 1) | - (!!test_bit(LED_NUML, dev->led)); + (!!test_bit(LED_NUML, dev->led) << 0); if (session->leds == newleds) return 0;