From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: Sun, 18 Feb 2018 22:36:18 +0000 (+0100)
Subject: rtc: stk17ta8: let the core handle invalid time
X-Git-Tag: v4.19~1240^2~68
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bd7f4e7598921506c2ae343954fdbb764840921b;p=platform%2Fkernel%2Flinux-rpi.git

rtc: stk17ta8: let the core handle invalid time

Returning a valid time when the time is invalid is a bad practice, because
then userspace is not able to react on the information. Also, it doesn't
make sense to return epoch because it is already the default time.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---

diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c
index 01a3bef..e70b78d 100644
--- a/drivers/rtc/rtc-stk17ta8.c
+++ b/drivers/rtc/rtc-stk17ta8.c
@@ -129,10 +129,6 @@ static int stk17ta8_rtc_read_time(struct device *dev, struct rtc_time *tm)
 	/* year is 1900 + tm->tm_year */
 	tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900;
 
-	if (rtc_valid_tm(tm) < 0) {
-		dev_err(dev, "retrieved date/time is not valid.\n");
-		rtc_time_to_tm(0, tm);
-	}
 	return 0;
 }