From: Łukasz Stelmach Date: Thu, 8 Apr 2021 12:09:24 +0000 (+0200) Subject: logger: Fix incorrect buffer access when writing data X-Git-Tag: accepted/tizen/unified/20211126.111914~15^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bd7484017b772ec4fec2e75477df361ff6d1d29c;p=platform%2Fkernel%2Flinux-tizen-modules-source.git logger: Fix incorrect buffer access when writing data Fix crash caused by accessing memory beyond log->buffer Change-Id: I528b62e34e9fb5f92f62f6b218718e15cd5f7d31 Signed-off-by: Łukasz Stelmach --- diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c index 8988e4b..fb6afb3 100644 --- a/drivers/staging/android/logger.c +++ b/drivers/staging/android/logger.c @@ -531,7 +531,7 @@ static void write_log_data(struct logger_log *log, /* message */ len = min(chunk_len, log->size - w_off); - memcpy(log->buffer + w_off, writer->buffer, chunk_len); + memcpy(log->buffer + w_off, writer->buffer, len); memcpy(log->buffer, writer->buffer + len, chunk_len - len); log->w_off = logger_offset(log, w_off + chunk_len); }