From: Jan Beulich Date: Wed, 29 May 2013 12:18:56 +0000 (+0100) Subject: improve modalias building X-Git-Tag: upstream/snapshot3+hdmi~4731^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bd70134396622ea50b14e34dae0810879884d553;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git improve modalias building For one, there's no point in the respective pieces to be rebuilt unconditionally on each and every rebuild. Second there's no need to invent a custom rule for generating the .s file from the .c source - we can simply use the generic rule here. And finally, $(obj) should be used to refer to files in the build tree (rather than spelling out the subdirectory). Signed-off-by: Jan Beulich Signed-off-by: Michal Marek --- diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile index ae21b89..c11212f 100644 --- a/scripts/mod/Makefile +++ b/scripts/mod/Makefile @@ -29,15 +29,10 @@ define cmd_offsets echo "#endif" ) > $@ endef -# We use internal kbuild rules to avoid the "is up to date" message from make -scripts/mod/devicetable-offsets.s: scripts/mod/devicetable-offsets.c FORCE - $(Q)mkdir -p $(dir $@) - $(call if_changed_dep,cc_s_c) +$(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s + $(call if_changed,offsets) -$(obj)/$(devicetable-offsets-file): scripts/mod/devicetable-offsets.s - $(call cmd,offsets) - -targets += $(devicetable-offsets-file) +targets += $(devicetable-offsets-file) devicetable-offsets.s # dependencies on generated files need to be listed explicitly