From: alexandre.rames@arm.com Date: Thu, 20 Mar 2014 15:25:27 +0000 (+0000) Subject: A64: Restore the stack limit protection to 1KB. X-Git-Tag: upstream/4.7.83~10118 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bd69f65394de1bcd466d3b54f164c83e9b5db91e;p=platform%2Fupstream%2Fv8.git A64: Restore the stack limit protection to 1KB. R=ulan@chromium.org Review URL: https://codereview.chromium.org/206393002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/a64/simulator-a64.cc b/src/a64/simulator-a64.cc index d414bf542..a401c62d2 100644 --- a/src/a64/simulator-a64.cc +++ b/src/a64/simulator-a64.cc @@ -359,12 +359,7 @@ uintptr_t Simulator::PopAddress() { uintptr_t Simulator::StackLimit() const { // Leave a safety margin of 1024 bytes to prevent overrunning the stack when // pushing values. - // TODO(all): Increase the stack limit protection. - - // The margin was decreased to 256 bytes, because we are intensively using - // the stack. The stack usage should decrease when our code improves. Then - // we can set it to 1024 again. - return reinterpret_cast(stack_limit_) + 256; + return reinterpret_cast(stack_limit_) + 1024; } diff --git a/src/a64/simulator-a64.h b/src/a64/simulator-a64.h index 0d973e835..1ef891a15 100644 --- a/src/a64/simulator-a64.h +++ b/src/a64/simulator-a64.h @@ -833,7 +833,6 @@ class Simulator : public DecoderVisitor { static const intptr_t stack_protection_size_ = KB; intptr_t stack_size_; byte* stack_limit_; - // TODO(aleram): protect the stack. Decoder* decoder_; Decoder* disassembler_decoder_;