From: Pavel Begunkov Date: Mon, 9 Jan 2023 14:46:04 +0000 (+0000) Subject: io_uring: refactor io_wake_function X-Git-Tag: v6.6.7~3537^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bd550173acc2dc782d9c57852f6b6e71f5d9a159;p=platform%2Fkernel%2Flinux-starfive.git io_uring: refactor io_wake_function Remove a local variable ctx in io_wake_function(), we don't need it if io_should_wake() triggers it to wake up. Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/e60eb1008aebe286aab7d34c772ed01c447bddb1.1673274244.git.asml.silence@gmail.com Signed-off-by: Jens Axboe --- diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index fdea6fb..5e1a084 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -2439,15 +2439,13 @@ static inline bool io_should_wake(struct io_wait_queue *iowq) static int io_wake_function(struct wait_queue_entry *curr, unsigned int mode, int wake_flags, void *key) { - struct io_wait_queue *iowq = container_of(curr, struct io_wait_queue, - wq); - struct io_ring_ctx *ctx = iowq->ctx; + struct io_wait_queue *iowq = container_of(curr, struct io_wait_queue, wq); /* * Cannot safely flush overflowed CQEs from here, ensure we wake up * the task, and the next invocation will do it. */ - if (io_should_wake(iowq) || io_has_work(ctx)) + if (io_should_wake(iowq) || io_has_work(iowq->ctx)) return autoremove_wake_function(curr, mode, wake_flags, key); return -1; }