From: Luck, Tony <tony.luck@intel.com> Date: Wed, 16 Nov 2011 18:50:56 +0000 (-0800) Subject: fix typo/thinko in get_random_bytes() X-Git-Tag: v3.2~242 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bd29e568a4cb6465f6e5ec7c1c1f3ae7d99cbec1;p=platform%2Fkernel%2Flinux-amlogic.git fix typo/thinko in get_random_bytes() If there is an architecture-specific random number generator we use it to acquire randomness one "long" at a time. We should put these random words into consecutive words in the result buffer - not just overwrite the first word again and again. Signed-off-by: Tony Luck <tony.luck@intel.com> Acked-by: H. Peter Anvin <hpa@zytor.com> Acked-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> --- diff --git a/drivers/char/random.c b/drivers/char/random.c index 63e19ba56bbe..6035ab8d5ef7 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -941,7 +941,7 @@ void get_random_bytes(void *buf, int nbytes) if (!arch_get_random_long(&v)) break; - memcpy(buf, &v, chunk); + memcpy(p, &v, chunk); p += chunk; nbytes -= chunk; }