From: Davis Goodin <dagood@microsoft.com>
Date: Mon, 6 May 2019 22:15:58 +0000 (-0500)
Subject: Use e.g. bin/obj/sfx/windowsdesktop for short path
X-Git-Tag: submit/tizen/20210909.063632~11032^2~206^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bc8b37a3267ae5cde50f11b1adaf6715462895c8;p=platform%2Fupstream%2Fdotnet%2Fruntime.git

Use e.g. bin/obj/sfx/windowsdesktop for short path


Commit migrated from https://github.com/dotnet/core-setup/commit/d8403937894c8c600d4bad8cc140f59e5390e92b
---

diff --git a/src/installer/pkg/packaging-tools/framework.packaging.targets b/src/installer/pkg/packaging-tools/framework.packaging.targets
index 9188524..dc77e8d 100644
--- a/src/installer/pkg/packaging-tools/framework.packaging.targets
+++ b/src/installer/pkg/packaging-tools/framework.packaging.targets
@@ -329,7 +329,18 @@
   <Target Name="GenerateSharedFramework"
           Condition="'$(GenerateSharedFramework)' == 'true'">
     <PropertyGroup>
-      <SharedFrameworkIntermediateOutputPath>$(IntermediateOutputPath)sfx/</SharedFrameworkIntermediateOutputPath>
+      <!--
+        For the sfx intermediate path, use 'bin/obj/sfx/', without OSPlatformConfig (RID +
+        Release/Debug). This is to save on path chars, which are at a premium. if the Git clone root
+        is even a little deep, Windows max path is a big problem. Package caches are a particular
+        problem due to long IDs, long versions, and deep resource DLLs with big names.
+
+        The OSPlatformConfig is normally in the intermediate path because it allows building
+        different configurations without cleaning the repo in between. This can be valuable for dev
+        builds. Not including OSPlatformConfig is ok in this target because the intermediate dir is
+        always deleted before it's used.
+      -->
+      <SharedFrameworkIntermediateOutputPath>$(BaseIntermediateOutputPath)sfx/$(ShortFrameworkName)/</SharedFrameworkIntermediateOutputPath>
     </PropertyGroup>
 
     <!-- Delete layout directory and sfx NuGet cache to ensure freshness. -->
diff --git a/src/installer/pkg/packaging-tools/sharedFramework/sharedFramework.csproj b/src/installer/pkg/packaging-tools/sharedFramework/sharedFramework.csproj
index 92c4062..6ab6ad8 100644
--- a/src/installer/pkg/packaging-tools/sharedFramework/sharedFramework.csproj
+++ b/src/installer/pkg/packaging-tools/sharedFramework/sharedFramework.csproj
@@ -31,7 +31,7 @@
     <DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
     <!-- Don't error due to lack of runtime-specific deps, we're referencing those directly -->
     <EnsureRuntimePackageDependencies>false</EnsureRuntimePackageDependencies>
-    <!-- Use a project-local packages folder. 'p' rather than 'packages': stay under char limit. -->
+    <!-- Use a project-local packages folder. 'p', not 'packages': max path breathing room. -->
     <RestorePackagesPath>$(IntermediateOutputPath)p</RestorePackagesPath>
     <!-- Do not build or nor build in publish output or deps -->
     <NoBuild>true</NoBuild>