From: Youngjae Cho <y0.cho@samsung.com>
Date: Fri, 12 Apr 2024 05:27:07 +0000 (+0900)
Subject: halapi: Fix escaping condition to 'ret < 0' for consistency
X-Git-Tag: accepted/tizen/unified/20240611.122614~28
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bc80b16f1e62e688de1ae6b2a458a686537ff8dc;p=platform%2Fhal%2Fapi%2Fcommon.git

halapi: Fix escaping condition to 'ret < 0' for consistency

Change-Id: I6ef8a25ffcb54609c42fd21bf214984fb2241002
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
---

diff --git a/src/hal-api-compatibility-checker.c b/src/hal-api-compatibility-checker.c
index 8138386..f4b8079 100644
--- a/src/hal-api-compatibility-checker.c
+++ b/src/hal-api-compatibility-checker.c
@@ -199,7 +199,7 @@ static void make_compatibility_info_specific(struct halcc_hal *hal, void *user_d
 		return;
 
 	ret = halcc_hal_get_version(hal, &manifest_major, &manifest_minor, NULL);
-	if (ret != 0)
+	if (ret < 0)
 		return;
 
 	backend_major = data->major;
@@ -264,7 +264,7 @@ static void make_compatibility_info(void *data, void *user_data)
 	}
 
 	ret = hal_common_get_backend_version(module, &backend_major, &backend_minor);
-	if (ret != 0) {
+	if (ret < 0) {
 		set_compatibility_info_compat(module,
 			HAL_COMMON_BACKEND_COMPATIBILITY_INCOMPATIBLE,
 			"Backend has invalid version");
@@ -323,7 +323,7 @@ static int build_compatibility_manifest_dir(char *manifest_dir, int len)
 		return -EINVAL;
 
 	ret = get_tizen_hal_version(&manifest_major, &manifest_minor);
-	if (ret != 0) {
+	if (ret < 0) {
 		_E("Failed to get hal version, ret=%d\n", ret);
 		return ret;
 	}
@@ -376,7 +376,7 @@ static void store_backend_compatibility_to_storage(void)
 		return;
 
 	ret = set_owner(fd); // system_fw:system_fw
-	if (ret != 0) {
+	if (ret < 0) {
 		close(fd);
 		return;
 	}
@@ -394,7 +394,7 @@ static int load_backend_compatibility_from_manifest(void *data)
 	int ret = 0;
 
 	ret = build_compatibility_manifest_dir(manifest_dir, sizeof(manifest_dir));
-	if (ret != 0)
+	if (ret < 0)
 		return ret;
 
 	ret = halcc_manifest_new(&manifest);
@@ -492,7 +492,7 @@ int hal_common_check_backend_compatibility_all(enum hal_common_backend_compatibi
 	enum hal_common_backend_compatibility *arr = NULL;
 
 	ret = load_backend_compatibility(NULL);
-	if (ret != 0)
+	if (ret < 0)
 		return ret;
 
 	if (access(HAL_COMMON_DEFAULT_BACKEND_COMPATIBILITY_PATH, F_OK) != 0)
@@ -531,7 +531,7 @@ int hal_common_check_backend_compatibility(enum hal_module module,
 		return -EINVAL;
 
 	ret = load_backend_compatibility(NULL);
-	if (ret != 0)
+	if (ret < 0)
 		return ret;
 
 	if (access(HAL_COMMON_DEFAULT_BACKEND_COMPATIBILITY_PATH, F_OK) != 0)
@@ -555,7 +555,7 @@ int _hal_common_check_backend_compatibility_by_version(enum hal_module module,
 	};
 
 	ret = load_backend_compatibility(&data);
-	if (ret != 0)
+	if (ret < 0)
 		return ret;
 
 	*compatibility = g_compatibility_info[module].compat;