From: Tasos Sahanidis Date: Thu, 26 Jan 2023 11:00:59 +0000 (+0100) Subject: media: saa7134: Use video_unregister_device for radio_dev X-Git-Tag: v6.6.17~5419^2~2^2~31 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bc7635c6435c77a0c168e2cc6535740adfaff4e4;p=platform%2Fkernel%2Flinux-rpi.git media: saa7134: Use video_unregister_device for radio_dev The radio device doesn't use vb2, thus calling vb2_video_unregister_device() which results in the following warning being printed on module unload. WARNING: CPU: 1 PID: 215963 at drivers/media/common/videobuf2/videobuf2-v4l2.c:1236 vb2_video_unregister_device+0xc6/0xe0 [videobuf2_v4l2] Fixes: 11788d9b7e91 ("media: media/pci: use vb2_video_unregister_device()") Signed-off-by: Tasos Sahanidis Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/drivers/media/pci/saa7134/saa7134-core.c index 96328b0..cf28713 100644 --- a/drivers/media/pci/saa7134/saa7134-core.c +++ b/drivers/media/pci/saa7134/saa7134-core.c @@ -978,7 +978,7 @@ static void saa7134_unregister_video(struct saa7134_dev *dev) } if (dev->radio_dev) { if (video_is_registered(dev->radio_dev)) - vb2_video_unregister_device(dev->radio_dev); + video_unregister_device(dev->radio_dev); else video_device_release(dev->radio_dev); dev->radio_dev = NULL;