From: Gu Zheng Date: Wed, 11 Sep 2013 21:23:21 +0000 (-0700) Subject: fs/bio-integrity: fix a potential mem leak X-Git-Tag: v3.12-rc1~52^2~150 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bc5c8f0783a4a2b43d05155782e71a22a91b26a5;p=profile%2Fivi%2Fkernel-x86-ivi.git fs/bio-integrity: fix a potential mem leak Free the bio_integrity_pool in the fail path of biovec_create_pool in function bioset_integrity_create(). Signed-off-by: Gu Zheng Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c index 8fb4291..6025084 100644 --- a/fs/bio-integrity.c +++ b/fs/bio-integrity.c @@ -716,13 +716,14 @@ int bioset_integrity_create(struct bio_set *bs, int pool_size) return 0; bs->bio_integrity_pool = mempool_create_slab_pool(pool_size, bip_slab); - - bs->bvec_integrity_pool = biovec_create_pool(bs, pool_size); - if (!bs->bvec_integrity_pool) + if (!bs->bio_integrity_pool) return -1; - if (!bs->bio_integrity_pool) + bs->bvec_integrity_pool = biovec_create_pool(bs, pool_size); + if (!bs->bvec_integrity_pool) { + mempool_destroy(bs->bio_integrity_pool); return -1; + } return 0; }