From: Ben Hutchings Date: Tue, 11 Sep 2012 17:25:13 +0000 (+0100) Subject: sfc: Fix check for failure of MC_CMD_FLUSH_RX_QUEUES X-Git-Tag: v3.8-rc1~139^2~143^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=bbec969b7f57a6ab5683145b99da869f99080e2a;p=platform%2Fkernel%2Flinux-stable.git sfc: Fix check for failure of MC_CMD_FLUSH_RX_QUEUES efx_mcdi_rpc_start() returns a negative value on error or zero on success. However one caller that can't properly handle failure then does WARN_ON(rc > 0). Change it to WARN_ON(rc < 0). Signed-off-by: Ben Hutchings --- diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c index aea43cb..e1967fb 100644 --- a/drivers/net/ethernet/sfc/mcdi.c +++ b/drivers/net/ethernet/sfc/mcdi.c @@ -1216,7 +1216,7 @@ int efx_mcdi_flush_rxqs(struct efx_nic *efx) rc = efx_mcdi_rpc(efx, MC_CMD_FLUSH_RX_QUEUES, (u8 *)qid, count * sizeof(*qid), NULL, 0, NULL); - WARN_ON(rc > 0); + WARN_ON(rc < 0); kfree(qid);